Conversation
romtsn
requested review from
adinauer,
lcian,
markushi and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
romtsn
commented
Apr 28, 2025
| adb shell setprop log.tag.BufferQueueProducer D | ||
| adb shell setprop log.tag.ReflectedParamUpdater D | ||
| adb shell setprop log.tag.hw-BpHwBinder D | ||
| adb shell setprop log.tag.ACodec D |
Member
Author
There was a problem hiding this comment.
I found these when running on a pixel device, so just added them here, not related to this PR
markushi
approved these changes
Apr 28, 2025
romtsn
added a commit
that referenced
this pull request
Jul 8, 2025
… in Compose (#4361) * WIP * fix(replay): Use global visible rect when text layout is not laid out in Compose * Revert * Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
When a
Textcomponent does not specify any font parameters (like fontSize, etc.), the underlyingTextLayoutreturns bogus values. So we're checking now if the fontSize != Unspecified (though there may be some other indicators we'd need to use in the future), and if it is we fallback to just masking by global visible bounds.Before
After
💡 Motivation and Context
Probably part of #4177
💚 How did you test it?
manually + automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps